Re: [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU'ssource code.

From: Paul E. McKenney
Date: Thu May 17 2012 - 18:44:39 EST


On Fri, May 18, 2012 at 12:27:31AM +0200, Peter Zijlstra wrote:
> On Thu, 2012-05-17 at 15:12 -0700, Paul E. McKenney wrote:
> > cnt += sprintf(&page[cnt],
> > - "rtc: %p ver: %lu tfle: %d rta: %d rtaf: %d rtf: %d "
> > - "rtmbe: %d rtbke: %ld rtbre: %ld "
> > - "rtbf: %ld rtb: %ld nt: %ld "
> > - "onoff: %ld/%ld:%ld/%ld "
> > - "barrier: %ld/%ld:%ld",
>
> The paranoid side of me would've used:
>
> cnt += snprintf(page + cnt, PAGE_SIZE - cnt, ...);

OK, added to the todo list. ;-)

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/