Re: [PATCH 2/3] perf script: Replace "struct thread" with "structaddr_location" as a parameter for "process_event()"

From: David Ahern
Date: Thu May 17 2012 - 12:08:20 EST


On 5/17/12 9:45 AM, Arnaldo Carvalho de Melo wrote:
Em Wed, May 16, 2012 at 08:59:14PM +0800, Feng Tang escreveu:
Both perl and python script start processing events other than trace
points, and it's useful to pass the resolved symbol and the dso info
to the event handler in script for better analysis and statistics.

Struct thread is already a member of struct addr_location, using
addr_location will keep the thread info, while providing additional
symbol and dso info if exist, so that the script itself doesn't need
to bother to do the symbol resolving and dso searching work.

This seems ok.

David, any objections or suggestions?

perf_event__preprocess_sample calls thread__find_addr_map which sets al->thread and the preprocess_sample is invoked prior to process_event, so it should be fine.

That said, I would like to test it. Unfortunately I am knee deep debugging some local perf breakage. Give me a couple of days to get back to this.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/