Re: [PATCH 3/8] i2c: i2c-bfin-twi: Break dead waiting loop if i2cdevice misbehaves.

From: Shubhrajyoti Datta
Date: Thu May 17 2012 - 06:51:54 EST


On Thu, May 17, 2012 at 10:53 AM, Mike Frysinger <vapier.adi@xxxxxxxxx> wrote:
> On Thu, May 17, 2012 at 1:20 AM, Shubhrajyoti Datta
> <omaplinuxkernel@xxxxxxxxx> wrote:
>> On Wed, May 16, 2012 at 12:50 PM,  <sonic.zhang@xxxxxxxxxx> wrote:
>>> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx>
>>>
>>> Some fault i2c device may hold the sda/scl line and cause i2c driver
>>> wait in the BUS busy loop. This patch breaks this potential dead
>>> loop.
>>
>> How about using a non-busy loop while you are at it.
>
> the timings here are fairly small ...
OK no issues.
Anyways was just a suggestion.:-)

> -mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/