[PATCH 7/8] MIPS: smp: Warn on too early irq enable

From: Yong Zhang
Date: Thu May 17 2012 - 06:12:02 EST


From: Yong Zhang <yong.zhang@xxxxxxxxxxxxx>

Just to catch a potential issue.

Signed-off-by: Yong Zhang <yong.zhang0@xxxxxxxxx>
---
arch/mips/kernel/smp.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 042145f..0d48598 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -130,6 +130,11 @@ asmlinkage __cpuinit void start_secondary(void)

synchronise_count_slave();

+ /*
+ * irq will be enabled in ->smp_finish(), enable it too early
+ * is dangerous.
+ */
+ WARN_ON_ONCE(!irqs_disabled());
mp_ops->smp_finish();

cpu_idle();
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/