Re: [PATCH 3/5] st: get rid of scsi_tapes array

From: James Bottomley
Date: Thu May 17 2012 - 03:35:31 EST


On Wed, 2012-05-16 at 20:56 -0700, Lee Duncan wrote:
> st currently allocates an array to store pointers to all of the
> scsi_tape objects. It's used to discover available indexes to use as the
> base for the minor number selection and later to look up scsi_tape
> devices for character devices.
>
> We switch to using an IDR for minor selection and a pointer from
> st_modedef back to scsi_tape for the lookups.
>
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
> Reviewed-by: Lee Duncan <lduncan@xxxxxxxx>

This can't be Reviewed-by either. The signoff chain has to follow the
transmission path of the patch. If you send me Jeff's patches, you have
to add a signoff because you're a direct part of the transmission path.
If Jeff sends me them, then he can give you Reviewed-by because you're
not then in the direct transmission path. (Signoff is supposed to imply
reviewed by anyway, so the tagging is correct in either case).

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/