Re: [PATCH] usb: fix breakage on systems without ACPI

From: Lan Tianyu
Date: Wed May 16 2012 - 10:05:04 EST


On 2012å5æ16æ 20:21:53, Greg KH wrote:
On Wed, May 16, 2012 at 02:11:15PM +0200, Sasha Levin wrote:
Commit da0af6e ("usb: Bind devices to ACPI devices when possible") really
tries to force-bind devices even when impossible, unlike what it says in
the subject.

CONFIG_ACPI is not an indication that ACPI tables are actually present, nor
is an indication that any USB relevant information is present in them. There
is no reason to fail the creation of a USB bus if it can't bind it to
ACPI device during initialization.

On systems with CONFIG_ACPI set but without ACPI tables it would cause a
boot panic.

Nice catch, sorry about that, I'll go queue this up.

greg k-h

Oh. Sorry for this. I just test it on some my machines that have usb descriptor.
bring trouble for you.

--
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/