Re: [PATCH] ptp_pch: Add missing #include <linux/slab.h>

From: Ben Hutchings
Date: Wed May 16 2012 - 07:40:58 EST


On Wed, 2012-05-16 at 10:43 +0200, Geert Uytterhoeven wrote:
> drivers/ptp/ptp_pch.c: In function 'pch_eth_enable_set':
> drivers/ptp/ptp_pch.c:152:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
> drivers/ptp/ptp_pch.c:153:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]

<linux/io.h> might be more useful.

Ben.

> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> Not even compile-tested, as it fails on parisc/xtensa only.
> http://kisskb.ellerman.id.au/kisskb/buildresult/6312813/
> http://kisskb.ellerman.id.au/kisskb/buildresult/6313050/
>
> drivers/ptp/ptp_pch.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c
> index 375eb04..6fff680 100644
> --- a/drivers/ptp/ptp_pch.c
> +++ b/drivers/ptp/ptp_pch.c
> @@ -30,6 +30,7 @@
> #include <linux/module.h>
> #include <linux/pci.h>
> #include <linux/ptp_clock_kernel.h>
> +#include <linux/slab.h>
>
> #define STATION_ADDR_LEN 20
> #define PCI_DEVICE_ID_PCH_1588 0x8819

--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.

Attachment: signature.asc
Description: This is a digitally signed message part