RE: [PATCH 2/4] Add parameter to control A/D bits support

From: Hao, Xudong
Date: Wed May 16 2012 - 06:40:20 EST


> -----Original Message-----
> From: Avi Kivity [mailto:avi@xxxxxxxxxx]
> Sent: Wednesday, May 16, 2012 5:15 PM
> To: Xudong Hao
> Cc: kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Shan, Haitao; Zhang,
> Xiantao; Hao, Xudong
> Subject: Re: [PATCH 2/4] Add parameter to control A/D bits support
>
> On 05/16/2012 04:08 AM, Xudong Hao wrote:
> > Add kernel parameter to control A/D bits support, it's on by default.
> >
> > Signed-off-by: Haitao Shan <haitao.shan@xxxxxxxxx>
> > Signed-off-by: Xudong Hao <xudong.hao@xxxxxxxxx>
> >
> > ---
> > arch/x86/kvm/vmx.c | 12 ++++++++++++
> > 1 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > index d2bd719..811a61e 100644
> > --- a/arch/x86/kvm/vmx.c
> > +++ b/arch/x86/kvm/vmx.c
> > @@ -64,6 +64,9 @@ static bool __read_mostly enable_unrestricted_guest =
> 1;
> > module_param_named(unrestricted_guest,
> > enable_unrestricted_guest, bool, S_IRUGO);
> >
> > +static int __read_mostly enable_ept_ad_bits = 1;
> > +module_param_named(ept_ad_bits, enable_ept_ad_bits, bool, S_IRUGO);
>
> Please use bool. And call the external name 'eptad', for easier use.
>

OK, will modify them in patch v2.

Thanks,
-Xudong

>
> --
> error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/