Re: [PATCH] mbxfb: unbreak compilation with CONFIG_FB_MBX_DEBUG

[Eric Miao]

On Tue, May 15, 2012 at 12:31 AM,  <tartler@xxxxxxxxx> wrote:
> From: Reinhard Tartler <siretart@xxxxxxxxxx>
>
> This patch adds missing function prototypes.
>
> Signed-off-by: Reinhard Tartler <tartler@xxxxxxxxx>
> ---
> Âdrivers/video/mbx/mbxfb.c | Â Â3 +++
> Â1 file changed, 3 insertions(+)
>
> This patch was found with tools developed in the VAMOS project:
> http://www4.cs.fau.de/Research/VAMOS/
>
> TBH, I'm not sure if this is the correct solution. However, I'd
> appreciate if someone could confirm that this is a real bug.

This looks to be a correct solution to me.

Acked-by: Eric Miao <eric.y.miao@xxxxxxxxx>

>
>
> diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
> index 6ce3416..c2200ec 100644
> --- a/drivers/video/mbx/mbxfb.c
> +++ b/drivers/video/mbx/mbxfb.c
> @@ -878,6 +878,9 @@ static int mbxfb_resume(struct platform_device *dev)
> Â#ifndef CONFIG_FB_MBX_DEBUG
> Â#define mbxfb_debugfs_init(x) Âdo {} while(0)
> Â#define mbxfb_debugfs_remove(x) Â Â Â Âdo {} while(0)
> +#else
> +void mbxfb_debugfs_init(struct fb_info *fbi);
> +void mbxfb_debugfs_remove(struct fb_info *fbi);
> Â#endif
>
> Â#define res_size(_r) (((_r)->end - (_r)->start) + 1)
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/