Re: [PATCH 3/4] REGULATOR: regulator driver for Palmas series chips

[Mark Brown]

On Tue, May 15, 2012 at 03:12:45PM +0900, Graeme Gregory wrote:
> On 14/05/12 17:52, Mark Brown wrote:
> > On Mon, May 14, 2012 at 10:58:31AM +0900, Graeme Gregory wrote:

> >> +
> >> +	palmas_ldo_write(pmic->palmas, palmas_regs_info[id].ctrl_addr, reg);

> > Could use the core regmap stuff for the LDOs too.

> Enable/Disable now use regmap but is_enabled cant as it reads from a
> different bitmask.

Yeah, I did notice that and actually meant to go back and say that
really your current is_enabled() ought to be get_status().  The former
is supposed to return what the driver request to the hardware is, the
latter is supposed to return what the physical status is.  Not super
critical though.

Attachment: signature.asc
Description: Digital signature