Re: [PATCH] MTD: LPC32xx MLC NAND driver

From: Roland Stigge
Date: Tue May 15 2012 - 11:56:33 EST


On 05/15/2012 05:49 PM, Roland Stigge wrote:
>>> +
>>> + sg_init_one(&host->sgl, mem, len);
>>> +
>>> + res = dma_map_sg(host->dma_chan->device->dev, &host->sgl, 1, dir);
>>
>> Also note that dma transfer directions and dma data directions are
>> different things. You shouldn't mix the two.

Can I safely use DMA_BIDIRECTIONAL here (practically, it works - just
tested), because the caller asks for read _or_ write? Or do I need to
formally convert enum dma_transfer_direction to enum dma_data_direction?

Thanks in advance,

Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/