Re: [34-longterm 179/179] x86/PCI: do not tie MSI MS-7253 use_crsquirk to BIOS version

From: Alan Cox
Date: Tue May 15 2012 - 10:42:07 EST


O> MS-7253, for which we already have a quirk, but the short-sighted
> author tied the quirk to a single BIOS version, making it not kick in

It's our usual policy to tie to particular BIOS versions because these
things are often BIOS specific and come and go with updates.

So I think short-sighted is unfair - appropriately conserative is closer.

> on Carlos's machine with BIOS V1.2. If a later BIOS update makes it
> no longer necessary to look at the _CRS info it will still be
> harmless, so let's stop trying to guess which versions have and don't
> have accurate _CRS tables.

Have you verified there are no BIOSes > v1.6 and that none of them have
release notes or testing showing fixes related to this ? Adding 1.2 is
fine but you are just asking for a regression on 1.7+ or similar.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/