Re: suspicious RCU usage in security/selinux/netnode.c

[Eric Paris]

On Tue, May 15, 2012 at 1:16 AM, Paul E. McKenney
<paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> On Tue, May 15, 2012 at 12:41:45AM -0400, Dave Jones wrote:
>> I just triggered this on Linus' current tree.
>
> This is a bare:
>
>        rcu_dereference(sel_netnode_hash[idx].list.prev)
>
> which needs to be in an RCU read-side critical section.  Alternatively,
> the above should instead be something like:
>
>        rcu_dereference_check(sel_netnode_hash[idx].list.prev,
>                              lockdep_is_held(&sel_netnode_lock));

Right, but that 'bare' dereference comes from
list_for_each_entry_rcu(), [from sel_netnode_sid_slow()] which I don't
see how to easily annotate with the lock.  Nor do I think it's within
my brain power (or my willingness to maintain such in the future) to
want to open code that logic.

Should we just take the rcu_read_lock() where we take the spinlock?
Is that a perf hit and figuring out how to do the annotation correctly
is the better idea?

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/