Re: [PATCH 00/12] pinctrl for Ux500 and Nomadik family

[Linus Walleij]

On Tue, May 15, 2012 at 1:24 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> I get build errors with nhk8815_defconfig after this:
>
> arch/arm/mach-nomadik/built-in.o: In function `nhk8815_eth_init':
> /home/arnd/linux-arm/arch/arm/mach-nomadik/board-nhk8815.c:224: undefined reference to `nmk_gpio_set_mode'
> arch/arm/mach-nomadik/built-in.o: In function `nhk8815_i2c_init':
> /home/arnd/linux-arm/arch/arm/mach-nomadik/i2c-8815nhk.c:46: undefined reference to `nmk_gpio_set_mode'
> /home/arnd/linux-arm/arch/arm/mach-nomadik/i2c-8815nhk.c:47: undefined reference to `nmk_gpio_set_mode'
> /home/arnd/linux-arm/arch/arm/mach-nomadik/i2c-8815nhk.c:50: undefined reference to `nmk_gpio_set_mode'
> /home/arnd/linux-arm/arch/arm/mach-nomadik/i2c-8815nhk.c:51: undefined reference to `nmk_gpio_set_mode'
>
> Here is my suggested fix:

This looks perfect Arnd, thanks for fixing this!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I plan to migrate also the Nomadik to pinctrl and delete the old open-coded
interfaces in the driver for the next kernel cycle.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/