Re: [PATCH] perf-record: Create events initially disabled -- again

From: David Ahern
Date: Mon May 14 2012 - 21:42:30 EST


On 5/14/12 7:07 PM, Namhyung Kim wrote:
Something else is wrong then. I tested that command (saw your patch in
the history) and it worked for me. Also, this code path does not
affect perf-stat -- it touches perf-record and perf-test only.


Ah, right. But still wouldn't it be better changing the conditional
rather than disabling it unconditionally?

Thanks,
Namhyung

I think it would be best to disable all events initially and then enable them when ready. It works for perf-record and perf-test just fine and limits the samples to what you care about.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/