Re: [PATCH v2] xfrm: take iphdr size into account for esp payloadsize calculation

From: David Miller
Date: Mon May 14 2012 - 18:42:43 EST


From: Benjamin Poirier <bpoirier@xxxxxxx>
Date: Thu, 10 May 2012 21:07:22 -0400

> - return mtu - 2;
> + return ((mtu - x->props.header_len - crypto_aead_authsize(esp->aead) -
> + l3_adj) & ~(align - 1)) + (l3_adj - 2);
> }

The formatting of this expression is completely wrong, you need
to make the "l3_adj" in the second line be aligned with the openning
parenthesis on the previous line at a depth determined based upon
how deeply in the openning parenthesis context this expression sits.

Just using TABS is ugly, and not allowed.

Use something like emacs's "C mode" with Linux coding style enabled
to assist you if you can't figure it out yourself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/