Re: [PATCH 2/5] Staging: ipack: add proper device model intoipack_bus_register.

[Greg Kroah-Hartman]

On Mon, May 14, 2012 at 12:41:26PM +0200, Samuel Iglesias Gonsalvez wrote:
> This patch adds a proper device model to the driver. The carrier boards are
> managed like other ipack device, the way to recognize them is using the
> platform data field from struct device.

Wait, what?  Why would you use the platform data field?  Why is that
needed at all?  You can specify the "type" of the device, but it seems
that you really want two different things here, busses and devices,
right?  So use two different devices and manage them differently, don't
make them the "same but different" by looking at the platform data
field.  That's not what the platform data field is for at all, sorry.

Please rework this patch, I can't take it as-is, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/