Re: [PATCH v2 2/2] Extcon: MAX8997: Add support irq domain forMAX8997 muic

From: Greg KH
Date: Mon May 14 2012 - 12:13:21 EST


On Fri, May 11, 2012 at 10:10:21AM +0900, Chanwoo Choi wrote:
> This patch add support irq domain for Maxim MAX8997 muic
> instead of irq_base in platform data and max8997 driver
> private data are instead. It is tested on TRATS board.
>
> v2
> - Fix typo when free_irq() in max8997_muic_probe()
>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/extcon/extcon-max8997.c | 28 +++++++++++++++++-----------
> 1 files changed, 17 insertions(+), 11 deletions(-)

This patch breaks the build on my system:

CC [M] drivers/extcon/extcon-max8997.o
drivers/extcon/extcon-max8997.c: In function âmax8997_muic_probeâ:
drivers/extcon/extcon-max8997.c:456:3: error: implicit declaration of function âirq_create_mappingâ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

So I can't accept these two patches, sorry. Please fix this up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/