Re: [PATCH] perf-record: Create events initially disabled -- again

[David Ahern]

On 5/14/12 7:09 AM, David Ahern wrote:
> > A problem I see is that it'll break group handling again:
> >
> > $ ./perf stat -g sleep 1
> >
> > Performance counter stats for 'sleep 1':
> >
> > <not counted> task-clock
> > <not counted> context-switches
> > <not counted> CPU-migrations
> > <not counted> page-faults
> > <not counted> cycles
> > <not counted> stalled-cycles-frontend
> > <not counted> stalled-cycles-backend
> > <not counted> instructions
> > <not counted> branches
> > <not counted> branch-misses
> >
> > 1.000868932 seconds time elapsed
> >
> > So I suggest changing perf_target__none() check to a proper one
> > (perf_target__no_cpu? - the name might be changed soon) for your
> > purpose.
> >
> > Thanks,
> > Namhyung
>
> Something else is wrong then. I tested that command (saw your patch in
> the history) and it worked for me. Also, this code path does not affect
> perf-stat -- it touches perf-record and perf-test only.

I think it is something else. I am running latest git tree (3.4.0-rc7). 
perf from Linus' tree and acme/core both show:

perf stat -g  -- find /usr >/dev/null

 Performance counter stats for 'find /usr':

     <not counted> task-clock
     <not counted> context-switches
     <not counted> CPU-migrations
     <not counted> page-faults
     <not counted> cycles
     <not counted> stalled-cycles-frontend
     <not counted> stalled-cycles-backend
     <not counted> instructions
     <not counted> branches
     <not counted> branch-misses

       0.111976940 seconds time elapsed


(Using find to make sure some work is done as opposed to sleep; openssl 
speed also shows the above.)

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/