Re: [PATCH 1/5] Staging ipack: fix a few sparse warnings

From: Samuel Iglesias Gonsálvez
Date: Mon May 14 2012 - 08:53:40 EST


On Mon, 2012-05-14 at 15:26 +0300, Dan Carpenter wrote:
> On Mon, May 14, 2012 at 12:41:25PM +0200, Samuel Iglesias Gonsalvez wrote:
> > /* Read status register */
> > - status_reg = readw((unsigned short *) (tpci200->info->interface_regs +
> > + status_reg = readw((void __iomem *) (tpci200->info->interface_regs +
> > TPCI200_STATUS_REG));
> >
>
> Later in the patch, you do the right thing which is to declare this
> as an __iomem pointer in the header. The cast here can be removed
> and it all fits on one line.
>
> Remove it in a follow on patch if you want. Same for several of the
> other casts in this patch.

Thanks a lot. I will do it.

Regards,

Sam


Attachment: signature.asc
Description: This is a digitally signed message part