RE: [PATCH] testusb: add path /dev/bus/usb to default search pathsfor usbfs

From: Du, ChangbinX
Date: Mon May 14 2012 - 06:49:07 EST



Hello.

On 14-05-2012 10:51, Du, ChangbinX wrote:

> As real device-nodes managed by udev whose nodes lived in /dev/bus/usb
> are mostly used today, let testusb tool use that directory as one
> default path make tool be more convenient to use.

> Signed-off-by: Du Changbin<changbinx.du@xxxxxxxxx>
> ---
> tools/usb/testusb.c | 6 ++++++
> 1 file changed, 6 insertions(+)

> diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index
> 6e0f567..c6c839e 100644
> --- a/tools/usb/testusb.c
> +++ b/tools/usb/testusb.c
[...]
> @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
> }
> } while (++it != end);
>
> + /* real device-nodes managed by udev */
> + if (access(udev_usb_path, F_OK) == 0) {
> + return udev_usb_path;
> + }

Why {} with single statement?

Hi, thanks for your tip. It's a code style issue. I will remove {}.

By the way, I don't know how I can do with this case? Resend a new patch? Do I need include discussion message in new patch mail?
And how can I know my patch has be accepted? I am a newbie, could you help me?

Changbin

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/