Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler

[Mark Brown]

On Mon, May 14, 2012 at 02:20:35PM +0900, Chanwoo Choi wrote:

> +	if (!max77693->irq) {
> +		dev_warn(max77693->dev, "No interrupt specified.\n");
> +		return 0;
> +	}

I'd suggest just setting up the IRQ domain anyway - it makes life
simpler in the other drivers for the chip as they don't need to worry if
interrupts are registered unless it's very important to them that they
go off which is often not the case.  Just skip actually claiming the
IRQ.

> +EXPORT_SYMBOL_GPL(max77693_irq_resume);
> +EXPORT_SYMBOL_GPL(max77693_irq_init);
> +EXPORT_SYMBOL_GPL(max77693_irq_exit);

These shouldn't need to be exported, they're only used by the MFD core.

Attachment: signature.asc
Description: Digital signature