Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry.

[OGAWA Hirofumi]

Joe Perches <joe@xxxxxxxxxxx> writes:

> On Sun, 2012-05-13 at 07:03 -0400, Namjae Jeon wrote:
>> So this patch use fat_msg_ratelimit function about this message to decrease this messages.
> []
>> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
>> index aca191b..b2cdbf4 100644
>> --- a/fs/fat/dir.c
>> +++ b/fs/fat/dir.c
>> @@ -98,8 +98,8 @@ next:
>>  
>>  	*bh = sb_bread(sb, phys);
>>  	if (*bh == NULL) {
>> -		fat_msg(sb, KERN_ERR, "Directory bread(block %llu) failed",
>> -		       (llu)phys);
>> +		fat_msg_ratelimit(sb, KERN_ERR, "Directory bread(block %llu) "
>> +				"failed", (llu)phys);
>
> Please don't split format strings.
> It's much harder to grep.

Please fight with 80 columns guys before requesting it.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/