Re: [PATCH] staging: comedi: Add helper macro for comedi pci driverboilerplate

[Ian Abbott]

On 2012-05-11 18:50, H Hartley Sweeten wrote:
> On Friday, May 11, 2012 10:42 AM, Ian Abbott wrote:
> > On 2012-05-11 18:34, H Hartley Sweeten wrote:
> > > On Friday, May 11, 2012 10:32 AM, Ian Abbott wrote:
> > > > On 2012-05-11 18:07, H Hartley Sweeten wrote:
> > > > > +int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
> > > > > +		struct pci_driver *pci_driver)
> > > > > +{
> > > > > +	int ret;
> > > > > +
> > > > > +	ret = comedi_driver_register(comedi_driver);
> > > > > +	if (ret<    0)
> > > > > +		return ret;
> > > > > +
> > > > > +	pci_driver->name = comedi_driver->driver_name;
> > > >
> > > > I think it would be better if the driver modules that call this function
> > > > already had pci_driver->name initialized statically.
> > >
> > > I agree, but this is how all the pci drivers do it now.
> > >
> > > To change this will require auditing all the comedi pci drivers and adding
> > > the static name.
> >
> > But if you're going to be calling this function from those drivers
> > anyway, you might as well add the static names at the same time!  Saves
> > another round of patches.
>
> True, but many of the pci drivers still need quite a bit of cleanup.
> After this patch was accepted I was going to just change the ones
> that have already had the init/exit stuff cleaned up. Then as I hit
> all the others I would change them.
>
> I guess I could do it this way:
>
> 1) add the "name" to all the pci drivers and remove the
> "pci_driver->name = comedi_driver->name" from all the
> module_init functions.
>
> 2) add the module_comedi_pci_driver stuff, without the
> "pci_driver->name = comedi_driver->name"
>
> 3) Update all the refactored comedi pci drivers to use
> the module_comedi_pci_driver macro.
>
> 4) As the other comedi pci drivers are refactored, use
> the module_comedi_pci_driver macro.
>
> How does that sound?

Okay, but I don't think it's worth doing three patches for each driver 
where one would do.  Adding a one-line .name = "foo", to the single 
patch for each driver you were planning to do anyway seems like a 
trivial addition that could be slotted into the patch without too much 
argument from the "one change per patch" folks, especially if you 
mention the purpose of that line in the commit message.  (I'd defer to 
the better judgement of Greg though.)

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/