Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-lengthrecord buffer

From: Sasha Levin
Date: Fri May 11 2012 - 11:22:51 EST


On Fri, May 11, 2012 at 5:19 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, May 11, 2012 at 12:35:07PM +0200, Sasha Levin wrote:
>> This has a small issue with the way timing is printed compared to how
>> it worked previously.
>>
>> Consider the following case:
>>
>>     printk("\n foo \n bar \n zoot")
>>
>> Previously, you would see timing on each line of the print, but now
>> you see it only on the first.
>
> What code does this?  Shouldn't those be individual printk lines?  I
> didn't think that type of line would ever work properly in the past.

At least the lockdep code, in several places:

__print_lock_name(safe_class);
printk(");\n");
printk("\n *** DEADLOCK ***\n\n");

Which has looked fine before.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/