Re: [PATCH v4 5/7] x86/tlb: add tlb flush all factor for specificCPU

[Alex Shi]

On 05/10/2012 06:42 PM, Borislav Petkov wrote:

> On Thu, May 10, 2012 at 11:38:35AM +0200, Peter Zijlstra wrote:
>> On Thu, 2012-05-10 at 13:00 +0800, Alex Shi wrote:
>>
>>
>>> +void intel_tlb_flushall_factor_set(struct cpuinfo_x86 *c)
>>> +{
>>> +       if (!cpu_has_invlpg) {
>>> +               tlb_flushall_factor = -1;
>>> +               return;
>>> +       }
>>
>> ...
>>
>>> +       if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB
>>> +                       || tlb_flushall_factor == (u16)TLB_FLUSH_ALL)
>>> {
>>>  flush_all: 
>>
>> Since you set tlb_flushall_factor (I'd have called it _shift)
> 
> Seconded, tlb_flushall_shift makes more sense, considering how it is
> being used.


OK. I will change the name.

> 
>> to -1 when !invlpg there's a redundant check in there.
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/