Re: [EDAC ABI v13 04/25] events/hw_event: Create a Hardware EventsReport Mecanism (HERM)

[Borislav Petkov]

On Thu, May 10, 2012 at 11:20:10AM -0400, Steven Rostedt wrote:
> On Thu, 2012-05-10 at 17:12 +0200, Borislav Petkov wrote:
> > On Thu, May 10, 2012 at 12:08:32PM -0300, Mauro Carvalho Chehab wrote:
> > > There's also another technical reason to give an acronym to the EDAC
> > > version that actually works: changeset numbers are not consistent
> > > within distributions (or other trees, like -stable - although this 60+
> > > patch series probably won't fit on -stable merging criteria).
> > >
> > > Also, this EDAC changeset 60+ patch series can't be represented by a
> > > single changeset, and requires userspace changes in order to get a
> > > proper representation model for memories.
> 
> Is this a redesign of EDAC or just a fix of it? Does this require
> userspace to use a new ABI?
> 
> > >
> > > Tagging the EDAC core version with a name helps a lot when dealing
> > > with all the unsolved bugzillas that will be closed by backporting
> > > this patch series in order to fix the serious EDAC core bug that
> > > were providing fake information to the end user for all Intel memory
> > > controllers manufactured after 2005.
> > 
> > edac_module.c:18:#define EDAC_VERSION "Ver: 2.1.0"
> > 
> > Increment that in the last patch.
> 
> If this is redesigning a subsystem and changing the ABI for userspace
> than a new name is appropriate. Much like ipchains turning into
> iptables.

But that's not the question. The subsystem is still called EDAC but
there's one patch which adds a tracepoint called trace_mc_error and this
is called needlessly a name - Hardware Events Report Mechanism - which
is only misleading and generating confusion even to its author.

Anyway, I think we solved the issue - we're going to increment
EDAC_VERSION and all is fine :-)

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/