Re: [PATCH RESEND 1/3] printk: convert byte-buffer tovariable-length record buffer

From: Joe Perches
Date: Wed May 09 2012 - 22:46:09 EST


On Thu, 2012-05-10 at 04:32 +0200, Kay Sievers wrote:
> --- a/kernel/printk.c
[]
> @@ -1295,20 +1296,16 @@ asmlinkage int vprintk_emit(int facility
> case '0' ... '7':
> if (level == -1)
> level = text[1] - '0';
> - text += 3;
> - textlen -= 3;
> - break;
> - case 'c': /* KERN_CONT */
> - cont = true;
> case 'd': /* KERN_DEFAULT */
> + prefix = true;
> + case 'c': /* KERN_CONT */

trivia:

Please add /* fallthrough */ comment lines
so it shows the "missing" breaks are intentional.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/