Re: I have question for supporting irq_domain of MAX8997

[Chanwoo Choi]

Dear Thomas,

On 05/09/2012 11:27 PM, Thomas Abraham wrote:

> The irq domain support for max8997 irq is already posted. I am yet to
> address some of the review comments for those patches and hence the
> max8997 dt (+ irqdomain) patches are still work in progress. But the
> irq domain support for max8997 is complete.

I did see your patch for irq_domain support for max8997 in below git repository.

http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=shortlog;h=refs/heads/for-next

But, I checked that your patch was reverted because it breaks the build
of the muic driver
reported by Stephen Rothwell. You can check this following url.
http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=82b719b11fd750188c125078ad6a6c0d23219dfb

Also, Do you test irq domain of MAX8997 with max8997-muic driver or others?
While looking through the drivers/mfd/max8997-irq.c, I could not find
initialization code
of max8997->irq_domain(field of 'struct max8997_dev'). When tested your
patch with
max8997-muic driver, max8997->irq_domain variable is NULL. I think that
you set only
local variable(struct irq_domain *domain) in max8997_irq_init().

Thank you,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/