Re: [PATCH] cciss: fix incorrect scsi status reporting

[Stephen Cameron]

On Wed, May 9, 2012 at 4:59 PM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 04 May 2012 13:21:14 -0500
> "Stephen M. Cameron" <scameron@xxxxxxxxxxxxxxxxxx> wrote:
>
>> From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>>
>> Delete code which sets SCSI status incorrectly as it's already
>> been set correctly above this incorrect code.  Bug was introduced
>> by b0e15f6db1110319cb2e747e59e1200450a5ba3e
>> "cciss: fix typo that causes scsi status to be lost." in 2009.
>>
>> Signed-off-by: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
>> Reported-and-tested-by: Roel van Meer <roel.vanmeer@xxxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx
>
> If the bug is three years old, it presumably isn't a terribly serious
> one.  Why was the -stable backport recommended?

(added roel.vanmeer@xxxxxxxxxx to cc list)

Due to my subjective interpretation of stable_kernel_rules.txt,
specifically this part:

 - It must fix a problem that causes a build error (but not for things
   marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
   security issue, or some "oh, that's not good" issue.  In short, something
   critical.

I thought it fell under the "oh, that's not good", in that, according
to the tester, iirc, it made his tape drive not show up at all, which
seemed bad (though not a symptom I observed directly), and it seemed
like a trivial fix to something obviously incorrect, so thought stable
might like to know about it.  But, maybe not.

-- steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/