Re: [PATCH 04/23] x86, realmode: Move reboot_32.S to unified realmodecode

[Paolo Bonzini]

Il 09/05/2012 15:53, H. Peter Anvin ha scritto:
>> > It's true that it doesn't matter much but still it is a
>> > regression. And it doesn't cause any kind of overhead
>> > or bloat to fix this.
>> > 
> However, the big thing is that we jump to the BIOS with caches off.  I
> personally think it is the wrong thing to do (we don't jump to the real
> reset vector anyway) but it is what has been tested for a long time.

I'm not sure I understand.  The code has

	andl	$0x60000000, %edx	; clear ET/PE
	jz	2f
	...
2:
	andb	$0x10, %dl		; clear CD/WT, %edx is always 0


What I've suggested is:

	testl	$0x60000000, %edx
	jz	2f
	...
2:
	andb	$0x10, %dl		; clear PE only


What would jump to the BIOS with caches on is:

	testl	$0x60000000, %edx
	jz	2f
	...
2:
	andl	$0x10, %edx		; Clear CD/WT/PE


Am I missing something?

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/