Re: [PATCH v2 14/16] mmc: block: Implement HPI invocation and handling logic.

From: kdorfman
Date: Wed May 09 2012 - 04:35:07 EST



> +static bool mmc_can_do_foreground_hpi(struct mmc_queue *mq,
> + struct request *req, unsigned int thpi)
> +{
> +
> + /*
> + * If some time has elapsed since the issuing of previous write
> + * command, or if the size of the request was too small, there's
> + * no point in preempting it. Check if it's worthwhile to preempt
> + */
> + int time_elapsed = jiffies_to_msecs(jiffies -
> + mq->mqrq_cur->mmc_active.mrq->cmd->started_time);
> +
> + if (time_elapsed <= thpi)
> + return true;
Some host controllers (or DMA) has possibility to get the byte count of
current transaction. It may be implemented as host api (similar to abort
ops). Then you have more accurate estimation of worthiness.

> +
> + return false;
> +}

Thanks, Kostya

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/