Re: [PATCH v3 7/7] x86/tlb: add tlb_flushall_factor into sysfs foruser change

From: H. Peter Anvin
Date: Tue May 08 2012 - 11:50:18 EST


On 05/08/2012 08:41 AM, Borislav Petkov wrote:
> On Tue, May 08, 2012 at 08:31:53AM -0700, H. Peter Anvin wrote:
>> On 05/08/2012 08:25 AM, Borislav Petkov wrote:
>>>
>>> Yep, this was supposed to be for pinpointing the proper entries count.
>>> I believe we don't have this thing of having code intree but not really
>>> intree - only for testing new silicon. Maybe a debug module or add this
>>> to debugfs?
>>>
>>
>> We have a lot of that kind of code, it is usually hidden under
>> CONFIG_*DEBUG* something.
>
> Then maybe this is where this knob should go, along with adding it to
> debugfs instead of sysfs...
>

I don't see a problem with it in sysfs.

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/