Re: [PATCH 0/3] scsi: usb-storage: hide errors for five devices

From: Alan Stern
Date: Tue May 08 2012 - 10:02:30 EST


On Tue, 8 May 2012, Paul Bolle wrote:

> 0) Five USB memory sticks I happen to have will generate sets of two
> errors when inserted. These sets are either:
> [...] Asking for cache data failed
> [...] Assuming drive cache: write through
>
> or:
> [...] No Caching mode page present
> [...] Assuming drive cache: write through
>
> These errors are generated by the SCSI stack (and printed thrice).
>
> 1) These patches try to hide those errors by:
> - downgrading one error to a notice; and

That's a reasonable thing to do, IMO.

> - setting the NO_WP_DETECT quirk for these five devices.

But that isn't. These quirks are intended for devices that crash when
they receive the command in question. They aren't meant to suppress
sending commands to devices that can properly reject them.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/