Re: [PATCH RESEND 1/3] printk: convert byte-buffer to variable-lengthrecord buffer

From: Sasha Levin
Date: Tue May 08 2012 - 04:49:14 EST


Hi Kay,

On Thu, May 3, 2012 at 2:29 AM, Kay Sievers <kay@xxxxxxxx> wrote:
> From: Kay Sievers <kay@xxxxxxxx>
> Subject: printk: convert byte-buffer to variable-length record buffer

This patch was included in today's linux-next, and it looks like it
broke printk on my configuration.

It's a bit hard to describe exactly what's wrong, but here are the main points:

1. PRINTK_TIME timing information is gone.
2. Newline issues. It appears to be adding newlines where it
shouldn't. For example:

Before:
[ 10.110626] parport0: PC-style at 0x378, irq 7 [PCSPP,TRISTATE]

After:
parport0: PC-style at 0x378
, irq 7
[
PCSPP
,TRISTATE
]

3. Things are not properly aligned, such as stack traces.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/