Re: [PATCH 1/3] lglock: remove online variants of lock

[Al Viro]

On Tue, May 08, 2012 at 01:29:45PM +0930, Rusty Russell wrote:
> Optimizing the slow paths adds a lot of complexity.  If you need to
> grab every lock often, you have other problems.

Applied, but I'm not too happy about the situation with vfsmount_lock ;-/
On kernels built for a lot of possible CPUs the loss of ..._online()
versions will get painful.  OTOH, we can always put the map + single
spinlock + single notifier into lglock.c and reproduce the old logics.
I'll do a patch along those lines and put it on a separate branch;
then we'll be able to test and compare.

Contention from cpu map spinlock becoming shared between different
lglocks (all two of them) is not an issue - we never use the
files_lock one anyway (there we can't use _online variants).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/