Re: [GIT PULL for 3.3-rc1] media updates

From: Laurent Pinchart
Date: Mon Apr 30 2012 - 07:23:01 EST


Hi Geert,

On Wednesday 25 April 2012 17:12:49 Geert Uytterhoeven wrote:
> On Sun, Jan 15, 2012 at 14:41, Mauro Carvalho Chehab wrote:
> > Laurent Pinchart (18):
> > [media] uvcvideo: Move fields from uvc_buffer::buf to uvc_buffer
> > [media] uvcvideo: Use videobuf2-vmalloc
>
> It seems these change (3d95e932573c316ad56b8e2f283e26de0b9c891c
> resp. 6998b6fb4b1c8f320adeee938d399c4d8dcc90e2) broke the
> build for nommu a while ago, as uvc_queue_get_unmapped_area() was not
> or was incorrectly updated:
>
> drivers/media/video/uvc/uvc_queue.c:254:23: error: 'struct
> uvc_video_queue' has no member named 'count'
> drivers/media/video/uvc/uvc_queue.c:255:18: error: 'struct
> uvc_video_queue' has no member named 'buffer'
> drivers/media/video/uvc/uvc_queue.c:256:19: error: 'struct vb2_buffer'
> has no member named 'm'
> drivers/media/video/uvc/uvc_queue.c:259:16: error: 'struct
> uvc_video_queue' has no member named 'count'
> drivers/media/video/uvc/uvc_queue.c:263:23: error: 'buf' undeclared
> (first use in this function)
>
> Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/6171077/

My bad, and thanks for the report. The following patch should fix this. Do you
have a NOMMU system to test it on ?