Re: [PATCH] IPVS: ip_vs_ftp.c: local functions should not be exposedglobally

From: Simon Horman
Date: Thu Apr 26 2012 - 21:01:41 EST


On Thu, Apr 26, 2012 at 11:17:28AM -0700, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent it from being exposed globally.
>
> This quiets the sparse warnings:
>
> warning: symbol 'ip_vs_ftp_init' was not declared. Should it be static?

On Thu, Apr 26, 2012 at 11:26:15AM -0700, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent it from being exposed globally.
>
> This quiets the sparse warnings:
>
> warning: symbol '__ipvs_proto_data_get' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>

Thanks, I have applied these to ipvs-next.

git://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/