Re: [PATCH] pinctrl: enhance reporting of errors when loading fromDT

[Stephen Warren]

On 04/26/2012 08:47 AM, John Crispin wrote:
> There are a few places in the api where the code simply returns -EINVAL when
> it finds an error. An example is pinmux_map_to_setting() which now reports an
> error if we try to match a group with a function that it does not support.
> 
> The reporting of errors in pinconf_check_ops and pinmux_check_ops now has the
> same style and is located inside the according functions and not the calling
> code.
> 
> When the map is found in the DT but the default state can not be selected we
> get an error to know that the code at least tried.
> 
> The patch also removes a stray word from one comment and a "->" from another
> for the sake of consistency.
> 
> Finally we replace a few pr_err/debug() calls with dev_err/dbg().
> 
> Thanks go to Stephen Warren for reviewing the patch and enhancing the reporting
> inside pinmux_map_to_setting().

Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/