[GIT PULL 0/4] perf/annotate loop detection V2, fixes

From: Arnaldo Carvalho de Melo
Date: Thu Apr 26 2012 - 11:06:38 EST


Hi Ingo,

Please consider pulling into tip/perf/core.

Just flushing out the annotate queue before it gets too big.

I'll work on the suggestions made on G+ and on lkml.

- Arnaldo

The following changes since commit a3f895be1f1ed17f66e6e71adeef0cc7f937512c:

perf annotate browser: Initial loop detection (2012-04-24 14:24:28 -0300)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-annotate-for-mingo

for you to fetch changes up to 38b31bd0cefbb0e69a182d9a94b09a7e648549dc:

perf annotate browser: Don't draw jump connectors for out of function jumps (2012-04-25 14:18:42 -0300)

----------------------------------------------------------------
Fixes on top of the previous perf/annotate pull request

. Sometimes a jump points to an offset with no instructions, make the
mark jump targets function handle that, for now just ignoring such
jump targets, more investigation is needed to figure out how to cope
with that.

. Handle jump targets that are outside the function, for now just don't
try to draw the connector arrow, right thing seems to be to mark this
jump with a -> (right arrow) and handle it like a callq.

Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
perf annotate browser: Handle NULL jump targets
perf annotate: Disambiguage offsets and addresses in operands
perf annotate: Mark jump instructions with no offset
perf annotate browser: Don't draw jump connectors for out of function jumps

tools/perf/ui/browsers/annotate.c | 27 ++++++++++++++++++---------
tools/perf/util/annotate.c | 27 +++++++++++++++------------
tools/perf/util/annotate.h | 13 +++++++++++--
3 files changed, 44 insertions(+), 23 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/