Re: [BUG] perf stat: useless output for raw events with new eventparser

[Robert Richter]

On 26.04.12 16:24:33, Peter Zijlstra wrote:
> On Thu, 2012-04-26 at 15:12 +0200, Robert Richter wrote:
> > On 26.04.12 12:27:11, Peter Zijlstra wrote:
> > > Furthermore, once we have a common format, we could even ask Intel/AMD
> > > (and other vendors) to provide their data in this format.
> > 
> > I don't think that can be done with a reasonable effort. 
> 
> I'm thinking you mis-understand, all we're talking about is a copy of
> your event list (BKDG Fam 10h Rev 3.48, section 3.14) in a usable
> format.

If it is not more complex than for libpfm4 am fine with it. I was
worried about describing pmu capabilities in sysfs which can better be
done with pmu specific code, once we know on which pmu we run.

> Its an aid to simplify constructing raw events, nothing more.
> 
> When I want to use funny events I'm staring at the Intel-SDM/AMD-BKDG
> anyway and I find writing:
> 
>   cpu/event=0x4e2,umask=0xf8/
> 
> A lot easier than:
> 
>   r40000f8e2

It is totally ok to have parser support for this. I simply do not see
why we need to put the encoding into sysfs. We somehow know on which
hardware we run and the parser should already know how to setup the
syscall. So parsing the above finally ends in calling of something
like:

 setup_event_for_some_pmu(event, 0x4e2, 0xf8);

We don't need any description of bit masks in sysfs for this.

> So I'd be perfectly ok with adding something
> like /sys/bus/events/device/*/name or so.

Yes, something like this could be added to let userland know about the
pmu.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/