Re: arch/arm/mach-s3c2410/Kconfig is unsourced

From: Kukjin Kim
Date: Tue Apr 24 2012 - 20:05:34 EST


Paul Bolle wrote:
0) commit 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c ("ARM: S3C2410: move
mach-s3c2410/* into mach-s3c24xx/") orphaned
arch/arm/mach-s3c2410/Kconfig: currently nothing sources that file in
Linus' tree.

Oops, you're right.

1) I haven't looked in depth at this, but this made S3C2410_PLLTABLE
disappear from the build system (ie, arch/arm/mach-s3c2410/pll.c is dead
code now). Moreover, this basically turned both "select S3C2410_CPUFREQ
if CPU_FREQ_S3C24XX", under "config CPU_S3C2410", and "select
S3C2410_IOTIMING if S3C2410_CPUFREQ", under "config ARCH_BAST", into
nops (both in arch/arm/mach-s3c24xx/Kconfig).

2) So to me it seems the move has only been done half: either more
things needs to be moved or those things can be removed entirely. But
perhaps arch/arm/mach-s3c2410/Kconfig should just be sourced again.

Yes, I think, would be better right now, if we could add just sourcing mach-s3c2410/Kconfig but as you said, I need to remove entire mach-s3c24 stuff.

Thanks for your pointing out and let me fix it.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/