Re: [PATCH 1/4] perf tools: Fix include header files inutil/parse-events.h

From: Arnaldo Carvalho de Melo
Date: Tue Apr 24 2012 - 13:36:01 EST


Em Tue, Apr 24, 2012 at 06:53:44PM +0200, Robert Richter escreveu:
> On 05.04.12 18:26:25, Robert Richter wrote:
> > Include header fixes for
> >
> > ... bool:
> >
> > util/parse-events.h:31: error: expected â=â, â,â, â;â, âasmâ or â__attribute__â before âhave_tracepointsâ
> >
> > ... and types.h:
> >
> > util/parse-events.h:28: error: expected â)â before âconfigâ
> > util/parse-events.h:34: error: expected declaration specifiers or â...â before âu64â
> > util/parse-events.h:45: error: expected â)â before âtypeâ
> >
> > This happens if now other include files are included before
> > util/parse-events.h.
> >
> > Signed-off-by: Robert Richter <robert.richter@xxxxxxx>
>
> Arnaldo,
>
> is it your intention that you didn't apply this patch?

Is this on perf/urgent or perf/core? In what system does this happen?

- Arnaldo

> Thanks,
>
> -Robert
>
> > ---
> > tools/perf/util/parse-events.h | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
> > index 6d7c74b..ab6ebe0 100644
> > --- a/tools/perf/util/parse-events.h
> > +++ b/tools/perf/util/parse-events.h
> > @@ -4,7 +4,9 @@
> > * Parse symbolic events/counts passed in as options:
> > */
> >
> > +#include <stdbool.h>
> > #include "../../../include/linux/perf_event.h"
> > +#include "types.h"
> >
> > struct list_head;
> > struct perf_evsel;
> > --
> > 1.7.8.4
> >
>
> --
> Advanced Micro Devices, Inc.
> Operating System Research Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/