Re: [PATCH] dmaengine/amba-pl08x : reset phychan_hold on terminate all

From: Linus Walleij
Date: Tue Apr 24 2012 - 09:08:38 EST


On Thu, Apr 19, 2012 at 12:20 PM, <ciminaghi@xxxxxxxxx> wrote:

> From: Davide Ciminaghi <ciminaghi@xxxxxxxxx>
>
> When a client calls pl08x_control with DMA_TERMINATE_ALL, it is correct
> to terminate and release the phy channel currently in use (if one is in use),
> but the phychan_hold counter must also be reset (otherwise it could get
> trapped in an unbalanced state).
>
> Signed-off-by: Davide Ciminaghi <ciminaghi@xxxxxxxxx>

Can't test it right now but looks convincingly correct:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/