Re: [PATCH] drivers/input/tablet/aiptek.c: adjust error-handlingcode label

From: Dmitry Torokhov
Date: Tue Apr 24 2012 - 01:29:03 EST


On Mon, Apr 16, 2012 at 10:44:52PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> At the point of this error-handling code, aiptek->urb has been allocated,
> and it does not appear to be less necessary to free it here than in the
> error-handling code just below.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Applied, thank you Julia.

>
> ---
> drivers/input/tablet/aiptek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
> index 205d16a..a33d347 100644
> --- a/drivers/input/tablet/aiptek.c
> +++ b/drivers/input/tablet/aiptek.c
> @@ -1856,7 +1856,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
> if (i == ARRAY_SIZE(speeds)) {
> dev_info(&intf->dev,
> "Aiptek tried all speeds, no sane response\n");
> - goto fail2;
> + goto fail3;
> }
>
> /* Associate this driver's struct with the usb interface.
>

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/