Re: [PATCH v4] set fake_rtable's dst to NULL to avoid kernel Oops

From: David Miller
Date: Tue Apr 24 2012 - 00:19:15 EST


From: "Peter Huang(Peng)" <peter.huangpeng@xxxxxxxxxx>
Date: Fri, 20 Apr 2012 14:12:51 +0800

> bridge: set fake_rtable's dst to NULL to avoid kernel Oops
>
> when bridge is deleted before tap/vif device's delete, kernel may
> encounter an oops because of NULL reference to fake_rtable's dst.
> Set fake_rtable's dst to NULL before sending packets out can solve
> this problem.
>
> v4 reformat, change br_drop_fake_rtable(skb) to {}
>
> v3 enrich commit header
>
> v2 introducing new flag DST_FAKE_RTABLE to dst_entry struct.
>
> Acked-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Signed-off-by: Peter Huang <peter.huangpeng@xxxxxxxxxx>

Applied, although I changed to nop br_drop_fake_rtable() implementation
to use "do { } while (0)" instead of just plain "{ }".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/