Re: [PATCH 33/43] userns: Convert binary formats to use kuid/kgid where appropriate
From: Eric W. Biederman
Date: Mon Apr 23 2012 - 22:40:36 EST
"Serge E. Hallyn" <serge@xxxxxxxxxx> writes:
> Quoting Eric W. Beiderman (ebiederm@xxxxxxxxxxxx):
>> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>>
>> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>
> Ok I'll spare the list the traffic - for patches 33-43,
>
> Acked-by: Serge Hallyn <serge.hallyn@xxxxxxxxxxxxx>
I noticed one other significant gotcha with my changes.
Code that has not been converted and needs to be converted fails to
build with type errors. -- Good.
Code that has not been converted and needs to be converted is still
selectable in make config. -- Bad
make oldmodconfig -- fails with type errors unless everything is
converted Bad.
So I am adding/debugging an additional patch that will catch these
failure in Kconfig so people don't get nasty surprises.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/