Re: [RFC PATCH v2 15/21] loop: use aio to perform io on the underlyingfile

[Maxim V. Patlasov]

On 04/20/2012 07:57 PM, Dave Kleikamp wrote:
> > So yeah, I'd agree that the loop code should be reworked a bit so that
> > both the filebacked and aio methods call vfs_sync() when they see
> > REQ_FLUSH.
> It's an easy fix. I don't anticipate that it will hurt performance too
> badly.

Two questions:

1. Could we use fdatasync there? (otherwise it can hurt performance very 
badly)

2. vfs_sync() is synchronous. loop_thread() will be blocked till it's 
completed. Would it be better to perform vfs_sync in another thread (to 
allow other bio-s in loop queue proceed)? Also, if there are more than 
one REQ_FLUSH bio in lo->lo_bio_list, we could call vfs_sync() only 
once. Make sense?

Thanks,
Maxim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/