Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

From: Josh Boyer
Date: Wed Apr 18 2012 - 10:12:01 EST


On Wed, Apr 18, 2012 at 03:08:54PM +0100, Bastien Nocera wrote:
> On Wed, 2012-04-18 at 10:05 -0400, Josh Boyer wrote:
> > Commit 4f5ca836b "HID: hid-input: add support for HID devices reporting
> > Battery Strength" added the CONFIG_HID_BATTERY_STRENGTH option to report
> > the battery strength of HID devices. The commit log explicitly mentions
> > it not working properly with recent userspace, but it is default y
> > anyway. This is rather odd, and actually causes problems on real
> > systems.
> >
> > This works around Fedora bug
> > https://bugzilla.redhat.com/show_bug.cgi?id=806295
>
> Don't. The only bit of user-space that's broken is upower, and it's
> getting a fixed release shortly.

Matthew suggested that additional kernel patches were required to add a
scope parameter so upower could understand that the battery is powering
a device and not the system.

Also, when did it become OK to force-enable a new feature that is
_known_ to not work properly on recent userspace? That makes no sense
to me.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/