Re: [PATCH v4 2/2] regulator: add device tree support for max8997
From: Thomas Abraham
Date: Wed Apr 18 2012 - 04:17:03 EST
Hi Mark,
On 18 April 2012 00:08, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Apr 18, 2012 at 12:05:59AM +0530, Thomas Abraham wrote:
>> On 28 March 2012 22:33, Karol Lewandowski <k.lewandowsk@xxxxxxxxxxx> wrote:
>
>> >> + For BUCK's:
>
> No 's here, BTW.
Ok.
>
>> > - EN32KHz_AP
>> > - EN32KHz_CP
>> > - ENVICHG
>> > - ESAFEOUT1
>> > - ESAFEOUT2
>> > - CHARGER
>> > - CHARGER_CV
>> > - CHARGER_TOPOFF
>
>> > I wonder if these should be mentioned in documentation too.
>
>> Yes, I missed the above regulators in the documentation. I have
>> included them now and will resubmit this patch.
>
> Please omit the clocks; these are obviously a bodge due to the inability
> to support clocks off-SoC so we shouldn't be enshrining them in the
> device tree bindings.
Thanks for the suggestion. I have removed EN32KHz_AP and EN32KHz_CP
from the list. The rest are either voltage (fixed) or current
regulators.
Regards,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/